From 0b4e8b468fc67806e0c0b2a0722929ea8fdb5bca Mon Sep 17 00:00:00 2001 From: hultonha Date: Wed, 21 Jul 2021 14:13:34 +0100 Subject: [PATCH] further formatting changes for viewport ui Signed-off-by: hultonha --- .../AzToolsFramework/ViewportUi/Button.cpp | 1 - .../AzToolsFramework/ViewportUi/Button.h | 4 ++-- .../AzToolsFramework/ViewportUi/ButtonGroup.h | 4 ++-- .../AzToolsFramework/ViewportUi/TextField.cpp | 4 +--- .../AzToolsFramework/ViewportUi/TextField.h | 7 +++--- .../ViewportUi/ViewportUiCluster.cpp | 1 - .../ViewportUi/ViewportUiDisplay.cpp | 1 - .../ViewportUi/ViewportUiDisplayLayout.cpp | 17 +++++++------ .../ViewportUi/ViewportUiDisplayLayout.h | 6 ++--- .../ViewportUi/ViewportUiManager.cpp | 24 +++++++------------ .../ViewportUi/ViewportUiManager.h | 2 +- .../ViewportUi/ViewportUiSwitcher.cpp | 23 +++++++++++++----- .../ViewportUi/ViewportUiSwitcher.h | 4 ++-- .../ViewportUi/ViewportUiTextField.cpp | 20 ++++++++++------ .../ViewportUi/ViewportUiTextField.h | 16 ++++++------- .../ViewportUi/ViewportUiWidgetCallbacks.cpp | 9 +++---- .../ViewportUi/ViewportUiWidgetCallbacks.h | 16 +++++++++---- 17 files changed, 86 insertions(+), 73 deletions(-) diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/Button.cpp b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/Button.cpp index 0d03271b93..3798bc1d22 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/Button.cpp +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/Button.cpp @@ -6,7 +6,6 @@ * */ - #include namespace AzToolsFramework::ViewportUi::Internal diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/Button.h b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/Button.h index 2bd35ba75d..b18f4723d8 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/Button.h +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/Button.h @@ -28,7 +28,7 @@ namespace AzToolsFramework::ViewportUi::Internal AZStd::string m_icon; //!< The icon for this button, string path to an image. AZStd::string m_name; //!< The name displayed as a label next to the button's icon. - State m_state = State::Deselected; - ButtonId m_buttonId; + State m_state = State::Deselected; + ButtonId m_buttonId; }; } // namespace AzToolsFramework::ViewportUi::Internal diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ButtonGroup.h b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ButtonGroup.h index 080ccb447e..0500a80c36 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ButtonGroup.h +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ButtonGroup.h @@ -1,5 +1,3 @@ -#pragma once - /* * Copyright (c) Contributors to the Open 3D Engine Project. * For complete copyright and license terms please see the LICENSE at the root of this distribution. @@ -8,6 +6,8 @@ * */ +#pragma once + #include namespace AzToolsFramework::ViewportUi::Internal diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/TextField.cpp b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/TextField.cpp index 44f856fe76..beb0db3147 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/TextField.cpp +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/TextField.cpp @@ -10,9 +10,7 @@ namespace AzToolsFramework::ViewportUi::Internal { - TextField::TextField( - const AZStd::string& labelText, const AZStd::string& fieldText, - TextFieldValidationType validationType) + TextField::TextField(const AZStd::string& labelText, const AZStd::string& fieldText, TextFieldValidationType validationType) : m_labelText(labelText) , m_fieldText(fieldText) , m_validationType(validationType) diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/TextField.h b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/TextField.h index 9cecf14fb8..682e4881b4 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/TextField.h +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/TextField.h @@ -19,16 +19,17 @@ namespace AzToolsFramework::ViewportUi::Internal { public: TextField( - const AZStd::string& labelText = "", const AZStd::string& fieldText = "", + const AZStd::string& labelText = "", + const AZStd::string& fieldText = "", TextFieldValidationType validationType = TextFieldValidationType::String); ~TextField() = default; void ConnectEventHandler(AZ::Event::Handler& handler); //! Default text for the text field. Will be cast to same type as m_validationType. - AZStd::string m_fieldText; + AZStd::string m_fieldText; AZStd::string m_labelText; - TextFieldValidationType m_validationType; // m_textEditedEvent; diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiCluster.cpp b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiCluster.cpp index f8d92cdda4..bc299f9985 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiCluster.cpp +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiCluster.cpp @@ -6,7 +6,6 @@ * */ - #include #include diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplay.cpp b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplay.cpp index 8710c94c4d..3b2c26114d 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplay.cpp +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplay.cpp @@ -6,7 +6,6 @@ * */ - #include #include #include diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplayLayout.cpp b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplayLayout.cpp index a6a472a181..f25d03a7be 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplayLayout.cpp +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplayLayout.cpp @@ -6,15 +6,19 @@ * */ - #include #include -#include + +#include namespace AzToolsFramework::ViewportUi::Internal { AZ_CVAR( - int, ViewportUiDisplayLayoutSpacing, 5, nullptr, AZ::ConsoleFunctorFlags::Null, + int, + ViewportUiDisplayLayoutSpacing, + 5, + nullptr, + AZ::ConsoleFunctorFlags::Null, "The spacing between elements attached to the Viewport UI Display Layout"); ViewportUiDisplayLayout::ViewportUiDisplayLayout(QWidget* parent) @@ -27,7 +31,7 @@ namespace AzToolsFramework::ViewportUi::Internal setSpacing(ViewportUiDisplayLayoutSpacing); // create a 3x2 map of sub layouts which will stack widgets according to their mapped alignment - m_internalLayouts = AZStd::unordered_map { + m_internalLayouts = AZStd::unordered_map{ CreateSubLayout(new QVBoxLayout(), 0, 0, Qt::AlignTop | Qt::AlignLeft), CreateSubLayout(new QVBoxLayout(), 1, 0, Qt::AlignBottom | Qt::AlignLeft), CreateSubLayout(new QVBoxLayout(), 0, 1, Qt::AlignTop), @@ -45,8 +49,7 @@ namespace AzToolsFramework::ViewportUi::Internal } // find the corresponding sub layout for the alignment and add the widget - if (auto layoutForAlignment = m_internalLayouts.find(alignment); - layoutForAlignment != m_internalLayouts.end()) + if (auto layoutForAlignment = m_internalLayouts.find(alignment); layoutForAlignment != m_internalLayouts.end()) { // place the widget before or after the invisible spacer // depending on the layout alignment @@ -97,7 +100,7 @@ namespace AzToolsFramework::ViewportUi::Internal // without this, alignment and resizing within the sublayouts becomes difficult layout->addStretch(1); - addLayout(layout, row, column, /*rowSpan=*/ 1, /*colSpan=*/ 1, alignment); + addLayout(layout, row, column, /*rowSpan=*/1, /*colSpan=*/1, alignment); return { alignment, layout }; } diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplayLayout.h b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplayLayout.h index 67fac85ec5..4a44f07491 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplayLayout.h +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiDisplayLayout.h @@ -9,8 +9,9 @@ #pragma once #include -#include + #include +#include #include namespace AzToolsFramework::ViewportUi::Internal @@ -33,8 +34,7 @@ namespace AzToolsFramework::ViewportUi::Internal private: //! Create a sub-layout to add to the grid of layouts. //! @return A pair of the new layout along with its alignment on the grid. - AZStd::pair CreateSubLayout( - QBoxLayout* layout, int row, int column, Qt::Alignment alignment); + AZStd::pair CreateSubLayout(QBoxLayout* layout, int row, int column, Qt::Alignment alignment); //! A mapping of each sub-layout to its corresponding alignment on the grid. AZStd::unordered_map m_internalLayouts; diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiManager.cpp b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiManager.cpp index 0ef00e006f..cee4a311e8 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiManager.cpp +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiManager.cpp @@ -6,12 +6,11 @@ * */ - #include #include #include -#include #include +#include namespace AzToolsFramework::ViewportUi { @@ -114,7 +113,8 @@ namespace AzToolsFramework::ViewportUi return ButtonId(0); } - const ButtonId ViewportUiManager::CreateSwitcherButton(const SwitcherId switcherId, const AZStd::string& icon, const AZStd::string& name) + const ButtonId ViewportUiManager::CreateSwitcherButton( + const SwitcherId switcherId, const AZStd::string& icon, const AZStd::string& name) { if (auto switcherIt = m_switcherButtonGroups.find(switcherId); switcherIt != m_switcherButtonGroups.end()) { @@ -146,8 +146,7 @@ namespace AzToolsFramework::ViewportUi } } - static void SetViewportUiElementVisible( - Internal::ViewportUiDisplay* ui, ViewportUiElementId id, bool visible) + static void SetViewportUiElementVisible(Internal::ViewportUiDisplay* ui, ViewportUiElementId id, bool visible) { if (visible) { @@ -186,11 +185,9 @@ namespace AzToolsFramework::ViewportUi } const TextFieldId ViewportUiManager::CreateTextField( - const AZStd::string& labelText, const AZStd::string& textFieldDefaultText, - TextFieldValidationType validationType) + const AZStd::string& labelText, const AZStd::string& textFieldDefaultText, TextFieldValidationType validationType) { - auto textField = AZStd::make_shared( - labelText, textFieldDefaultText, validationType); + auto textField = AZStd::make_shared(labelText, textFieldDefaultText, validationType); m_viewportUi->AddTextField(textField); return RegisterNewTextField(textField); @@ -206,8 +203,7 @@ namespace AzToolsFramework::ViewportUi } } - void ViewportUiManager::RegisterTextFieldCallback( - TextFieldId textFieldId, AZ::Event::Handler& handler) + void ViewportUiManager::RegisterTextFieldCallback(TextFieldId textFieldId, AZ::Event::Handler& handler) { if (auto textFieldIt = m_textFields.find(textFieldId); textFieldIt != m_textFields.end()) { @@ -234,7 +230,6 @@ namespace AzToolsFramework::ViewportUi } } - void ViewportUiManager::CreateComponentModeBorder(const AZStd::string& borderTitle) { m_viewportUi->CreateComponentModeBorder(borderTitle); @@ -248,8 +243,7 @@ namespace AzToolsFramework::ViewportUi void ViewportUiManager::PressButton(ClusterId clusterId, ButtonId buttonId) { // Find cluster using ID and cluster map - if (auto clusterIt = m_clusterButtonGroups.find(clusterId); - clusterIt != m_clusterButtonGroups.end()) + if (auto clusterIt = m_clusterButtonGroups.find(clusterId); clusterIt != m_clusterButtonGroups.end()) { clusterIt->second->PressButton(buttonId); } @@ -305,7 +299,7 @@ namespace AzToolsFramework::ViewportUi SwitcherId ViewportUiManager::RegisterNewSwitcher(AZStd::shared_ptr& buttonGroup) { SwitcherId newId = SwitcherId(m_switcherButtonGroups.size() + 1); - m_switcherButtonGroups.insert({newId, buttonGroup}); + m_switcherButtonGroups.insert({ newId, buttonGroup }); return newId; } diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiManager.h b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiManager.h index 6ab4bd9e5c..137ee7b2c0 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiManager.h +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiManager.h @@ -18,7 +18,7 @@ namespace AzToolsFramework::ViewportUi { class ButtonGroup; class ViewportUiDisplay; - } + } // namespace Internal class ViewportUiManager : public ViewportUiRequestBus::Handler { diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiSwitcher.cpp b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiSwitcher.cpp index 80f064c04a..6b8b1873f7 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiSwitcher.cpp +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiSwitcher.cpp @@ -65,8 +65,12 @@ namespace AzToolsFramework::ViewportUi::Internal // resize to fit new action with minimum extra space resize(minimumSizeHint()); - const AZStd::function& callback = [this, button]() { m_buttonGroup->PressButton(button->m_buttonId); }; - const AZStd::function& updateCallback = [button](QAction* action) { + const AZStd::function& callback = [this, button]() + { + m_buttonGroup->PressButton(button->m_buttonId); + }; + const AZStd::function& updateCallback = [button](QAction* action) + { action->setChecked(button->m_state == Button::State::Selected); }; @@ -78,9 +82,13 @@ namespace AzToolsFramework::ViewportUi::Internal // register the action m_widgetCallbacks.AddWidget( - action, [updateCallback](QPointer object) { updateCallback(static_cast(object.data())); }); + action, + [updateCallback](QPointer object) + { + updateCallback(static_cast(object.data())); + }); - m_buttonActionMap.insert({button->m_buttonId, action}); + m_buttonActionMap.insert({ button->m_buttonId, action }); } void ViewportUiSwitcher::RemoveButton(ButtonId buttonId) @@ -121,9 +129,12 @@ namespace AzToolsFramework::ViewportUi::Internal // Check if it is the first active mode to be set bool initialActiveMode = (m_activeButtonId == ButtonId(0)); - // Change the toolbutton's name and icon to that button + // Change the tool button's name and icon to that button const AZStd::vector buttons = m_buttonGroup->GetButtons(); - auto found = [buttonId](Button* button) { return (button->m_buttonId == buttonId); }; + auto found = [buttonId](Button* button) + { + return (button->m_buttonId == buttonId); + }; if (auto buttonIt = AZStd::find_if(buttons.begin(), buttons.end(), found); buttonIt != buttons.end()) { diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiSwitcher.h b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiSwitcher.h index 9af8774b6d..6620cb6aca 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiSwitcher.h +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiSwitcher.h @@ -8,11 +8,11 @@ #pragma once -#include #include #include +#include #include -#include + #include #include #include diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiTextField.cpp b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiTextField.cpp index d216749f99..d94c8d6dca 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiTextField.cpp +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiTextField.cpp @@ -6,7 +6,6 @@ * */ - #include "ViewportUiTextField.h" #include @@ -16,7 +15,11 @@ namespace AzToolsFramework::ViewportUi::Internal { AZ_CVAR( - int, ViewportUiTextFieldLength, 35, nullptr, AZ::ConsoleFunctorFlags::Null, + int, + ViewportUiTextFieldLength, + 35, + nullptr, + AZ::ConsoleFunctorFlags::Null, "The pixel length of the text field part of a ViewportUiTextField"); ViewportUiTextField::ViewportUiTextField(AZStd::shared_ptr textField) @@ -56,11 +59,14 @@ namespace AzToolsFramework::ViewportUi::Internal m_lineEdit.setValidator(m_validator); - connect(&m_lineEdit, &QLineEdit::textEdited, &m_lineEdit, [textField](QString text) { - // convert the text using toLocal8Bit().data() as recommended by Qt, then emit signal - textField->m_fieldText = text.toLocal8Bit().data(); - textField->m_textEditedEvent.Signal(textField->m_fieldText); - }); + connect( + &m_lineEdit, &QLineEdit::textEdited, &m_lineEdit, + [textField](QString text) + { + // convert the text using toLocal8Bit().data() as recommended by Qt, then emit signal + textField->m_fieldText = text.toLocal8Bit().data(); + textField->m_textEditedEvent.Signal(textField->m_fieldText); + }); } void ViewportUiTextField::Update() diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiTextField.h b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiTextField.h index ad56e78671..0e7a9043eb 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiTextField.h +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiTextField.h @@ -7,7 +7,10 @@ */ #pragma once + +#include #include + #include #include #include @@ -17,13 +20,10 @@ AZ_PUSH_DISABLE_WARNING(4251, "-Wunknown-warning-option") #include AZ_POP_DISABLE_WARNING -#include - namespace AzToolsFramework::ViewportUi::Internal { //! Helper class for a widget that holds and manages multiple LabelTextFields. - class ViewportUiTextField - : public QWidget + class ViewportUiTextField : public QWidget { Q_OBJECT @@ -34,9 +34,9 @@ namespace AzToolsFramework::ViewportUi::Internal void Update(); private: - QLabel m_label; // m_textField; // m_textField; //!< Reference to the text field data struct. }; } // namespace AzToolsFramework::ViewportUi::Internal diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiWidgetCallbacks.cpp b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiWidgetCallbacks.cpp index d86a4b7f06..1451912c82 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiWidgetCallbacks.cpp +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiWidgetCallbacks.cpp @@ -6,13 +6,11 @@ * */ - #include "ViewportUiWidgetCallbacks.h" namespace AzToolsFramework::ViewportUi::Internal { - void ViewportUiWidgetCallbacks::AddWidget( - QPointer widget, const AZStd::function)>& updateCallback) + void ViewportUiWidgetCallbacks::AddWidget(QPointer widget, const AZStd::function)>& updateCallback) { if (widget.isNull()) { @@ -40,7 +38,7 @@ namespace AzToolsFramework::ViewportUi::Internal { // if widget exists on the manager, register the callback auto callBackWidget = AZStd::find(m_widgets.begin(), m_widgets.end(), widget); - AZ_Assert(callBackWidget != m_widgets.end(), "Unable to register a callback for an unregistered widget.") + AZ_Assert(callBackWidget != m_widgets.end(), "Unable to register a callback for an unregistered widget."); if (callBackWidget != m_widgets.end()) { @@ -58,8 +56,7 @@ namespace AzToolsFramework::ViewportUi::Internal RemoveWidget(widget); } // check if the widget has not been deleted externally - else if (auto callback = m_updateCallbacks.find(widget); - callback != m_updateCallbacks.end()) + else if (auto callback = m_updateCallbacks.find(widget); callback != m_updateCallbacks.end()) { callback->second(widget); } diff --git a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiWidgetCallbacks.h b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiWidgetCallbacks.h index 5cf415f132..582f90349f 100644 --- a/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiWidgetCallbacks.h +++ b/Code/Framework/AzToolsFramework/AzToolsFramework/ViewportUi/ViewportUiWidgetCallbacks.h @@ -9,12 +9,12 @@ #pragma once #include -#include #include -#include -#include -#include +#include +#include +#include +#include namespace AzToolsFramework::ViewportUi::Internal { @@ -30,7 +30,8 @@ namespace AzToolsFramework::ViewportUi::Internal //! Must call ViewportUiWidgetCallbacks::Update to execute the callback. void RegisterUpdateCallback(QPointer widget, const AZStd::function)>& callback); void Update(); - const AZStd::vector>& GetWidgets() const { return m_widgets; } + + const AZStd::vector>& GetWidgets() const; protected: //! A map of all update callbacks and their respective widgets. @@ -38,4 +39,9 @@ namespace AzToolsFramework::ViewportUi::Internal AZStd::unordered_map)>> m_updateCallbacks; AZStd::vector> m_widgets; }; + + inline const AZStd::vector>& ViewportUiWidgetCallbacks::GetWidgets() const + { + return m_widgets; + } } // namespace AzToolsFramework::ViewportUi::Internal