birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

disable physics tick time warning in debug builds and make it less spammy (#827)

Browse Source
This commit is contained in:
amzn-sean
2021-05-20 15:39:39 +01:00
committed by GitHub
parent 8c35347cfb
commit 0b4b0698c7
1 changed files with 35 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gems/PhysX/Code/Source/System/PhysXSystem.cpp
+35 -3
View File
@@ -21,10 +21,25 @@
#include <PxPhysicsAPI.h> #include <PxPhysicsAPI.h>
// only enable physx timestep warning when not running debug or in Release
#if !defined(DEBUG) && !defined(RELEASE)
#define ENABLE_PHYSX_TIMESTEP_WARNING
#endif
namespace PhysX namespace PhysX
{ {
AZ_CLASS_ALLOCATOR_IMPL(PhysXSystem, AZ::SystemAllocator, 0); AZ_CLASS_ALLOCATOR_IMPL(PhysXSystem, AZ::SystemAllocator, 0);
#ifdef ENABLE_PHYSX_TIMESTEP_WARNING
namespace FrameTimeWarning
{
static constexpr int MaxSamples = 1000;
static int NumSamples = 0;
static int NumSamplesOverLimit = 0;
static float LostTime = 0.0f;
}
#endif
PhysXSystem::MaterialLibraryAssetHelper::MaterialLibraryAssetHelper(PhysXSystem* physXSystem) PhysXSystem::MaterialLibraryAssetHelper::MaterialLibraryAssetHelper(PhysXSystem* physXSystem)
: m_physXSystem(physXSystem) : m_physXSystem(physXSystem)
{ {
@@ -140,9 +155,26 @@ namespace PhysX
} }
}; };
AZ_Warning("PhysXSystem", deltaTime <= m_systemConfig.m_maxTimestep, #ifdef ENABLE_PHYSX_TIMESTEP_WARNING
"Frame delta time of [%.6f seconds] exceeds Physics max frame timestep, physics timestep will be clamped to [%.6f seconds].", if (FrameTimeWarning::NumSamples < FrameTimeWarning::MaxSamples)
deltaTime, m_systemConfig.m_maxTimestep); {
FrameTimeWarning::NumSamples++;
if (deltaTime > m_systemConfig.m_maxTimestep)
{
FrameTimeWarning::NumSamplesOverLimit++;
FrameTimeWarning::LostTime += deltaTime - m_systemConfig.m_maxTimestep;
}
}
else
{
AZ_Warning("PhysXSystem", FrameTimeWarning::NumSamplesOverLimit <= 0,
"[%d] of [%d] frames had a deltatime over the Max physics timestep[%.6f]. Physx timestep was clamped on those frames, losing [%.6f] seconds.",
FrameTimeWarning::NumSamplesOverLimit, FrameTimeWarning::NumSamples, m_systemConfig.m_maxTimestep, FrameTimeWarning::LostTime);
FrameTimeWarning::NumSamples = 0;
FrameTimeWarning::NumSamplesOverLimit = 0;
FrameTimeWarning::LostTime = 0.0f;
}
#endif
deltaTime = AZ::GetClamp(deltaTime, 0.0f, m_systemConfig.m_maxTimestep); deltaTime = AZ::GetClamp(deltaTime, 0.0f, m_systemConfig.m_maxTimestep);
AZ_Assert(m_systemConfig.m_fixedTimestep >= 0.0f, "PhysXSystem - fixed timestep is negitive."); AZ_Assert(m_systemConfig.m_fixedTimestep >= 0.0f, "PhysXSystem - fixed timestep is negitive.");