From 05a2ce4fe19fbc014975b1802b5408ac939d49d7 Mon Sep 17 00:00:00 2001 From: greerdv Date: Thu, 1 Jul 2021 13:35:57 +0100 Subject: [PATCH] update based on PR feedback Signed-off-by: greerdv --- .../AzFramework/Physics/Collision/CollisionGroups.cpp | 4 ++-- Gems/PhysX/Code/Tests/PhysXScriptTest.cpp | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Code/Framework/AzFramework/AzFramework/Physics/Collision/CollisionGroups.cpp b/Code/Framework/AzFramework/AzFramework/Physics/Collision/CollisionGroups.cpp index 3aab358aa4..a8c8c4470f 100644 --- a/Code/Framework/AzFramework/AzFramework/Physics/Collision/CollisionGroups.cpp +++ b/Code/Framework/AzFramework/AzFramework/Physics/Collision/CollisionGroups.cpp @@ -36,8 +36,8 @@ namespace AzPhysics void CollisionGroupScriptConstructor(CollisionGroup* thisPtr, AZ::ScriptDataContext& scriptDataContext) { - int numArgs = scriptDataContext.GetNumArguments(); - if (numArgs != 1) + if (int numArgs = scriptDataContext.GetNumArguments(); + numArgs != 1) { scriptDataContext.GetScriptContext()->Error(AZ::ScriptContext::ErrorType::Error, true, "CollisionGroup() accepts only 1 argument, not %d", numArgs); diff --git a/Gems/PhysX/Code/Tests/PhysXScriptTest.cpp b/Gems/PhysX/Code/Tests/PhysXScriptTest.cpp index ac9a731d54..7491ffe2f4 100644 --- a/Gems/PhysX/Code/Tests/PhysXScriptTest.cpp +++ b/Gems/PhysX/Code/Tests/PhysXScriptTest.cpp @@ -34,6 +34,8 @@ namespace PhysX return AZ::EntityId(); } + // this allows EXPECT_TRUE to be exposed to the behavior context and used inside blocks of lua code which + // are executed in tests void ExpectTrue(bool check) { EXPECT_TRUE(check);