From eb396be02e5f17713a4f6d6bb5b4b587657d8210 Mon Sep 17 00:00:00 2001 From: Stuart Boston Date: Thu, 25 Feb 2016 11:31:00 +0000 Subject: [PATCH] Remove unused constructors --- src/test/java/com/omertron/themoviedbapi/CompareTest.java | 6 ------ src/test/java/com/omertron/themoviedbapi/TestID.java | 3 ++- .../omertron/themoviedbapi/methods/TmdbAccountTest.java | 3 --- .../themoviedbapi/methods/TmdbAuthenticationTest.java | 7 ++----- .../themoviedbapi/methods/TmdbCertificationsTest.java | 3 --- .../omertron/themoviedbapi/methods/TmdbChangesTest.java | 3 --- .../themoviedbapi/methods/TmdbCollectionsTest.java | 3 --- .../omertron/themoviedbapi/methods/TmdbCompaniesTest.java | 3 --- .../themoviedbapi/methods/TmdbConfigurationTest.java | 3 --- .../omertron/themoviedbapi/methods/TmdbCreditsTest.java | 3 --- .../omertron/themoviedbapi/methods/TmdbDiscoverTest.java | 3 --- .../omertron/themoviedbapi/methods/TmdbEpisodesTest.java | 3 --- .../com/omertron/themoviedbapi/methods/TmdbFindTest.java | 3 --- .../com/omertron/themoviedbapi/methods/TmdbGenresTest.java | 3 --- .../omertron/themoviedbapi/methods/TmdbKeywordsTest.java | 3 --- .../com/omertron/themoviedbapi/methods/TmdbListsTest.java | 3 --- .../com/omertron/themoviedbapi/methods/TmdbMoviesTest.java | 3 --- .../omertron/themoviedbapi/methods/TmdbNetworksTest.java | 3 --- .../com/omertron/themoviedbapi/methods/TmdbPeopleTest.java | 3 --- .../omertron/themoviedbapi/methods/TmdbReviewsTest.java | 3 --- .../com/omertron/themoviedbapi/methods/TmdbSearchTest.java | 3 --- .../omertron/themoviedbapi/methods/TmdbSeasonsTest.java | 3 --- .../com/omertron/themoviedbapi/methods/TmdbTVTest.java | 3 --- 23 files changed, 4 insertions(+), 72 deletions(-) diff --git a/src/test/java/com/omertron/themoviedbapi/CompareTest.java b/src/test/java/com/omertron/themoviedbapi/CompareTest.java index d18d35cac..cb86dc281 100644 --- a/src/test/java/com/omertron/themoviedbapi/CompareTest.java +++ b/src/test/java/com/omertron/themoviedbapi/CompareTest.java @@ -21,14 +21,11 @@ package com.omertron.themoviedbapi; import com.omertron.themoviedbapi.model.movie.MovieInfo; import org.apache.commons.lang3.StringUtils; -import static org.junit.Assert.assertTrue; import org.junit.BeforeClass; import org.junit.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import static org.junit.Assert.assertTrue; -import static org.junit.Assert.assertTrue; -import static org.junit.Assert.assertTrue; /** * @@ -47,9 +44,6 @@ public class CompareTest { private static final boolean CASE_SENSITIVE = true; private static final boolean NOT_CASE_SENSITIVE = false; - public CompareTest() { - } - @BeforeClass public static void setUpClass() { TestLogger.configure(); diff --git a/src/test/java/com/omertron/themoviedbapi/TestID.java b/src/test/java/com/omertron/themoviedbapi/TestID.java index f75132ee3..e5091307a 100644 --- a/src/test/java/com/omertron/themoviedbapi/TestID.java +++ b/src/test/java/com/omertron/themoviedbapi/TestID.java @@ -29,7 +29,8 @@ public class TestID { private int tmdb; private String other; - public TestID() { + private TestID() { + throw new UnsupportedOperationException("Must use argument constructors"); } public TestID(String name, String imdb, int tmdb) { diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbAccountTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbAccountTest.java index 28a6b7a70..229297cb8 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbAccountTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbAccountTest.java @@ -51,9 +51,6 @@ public class TmdbAccountTest extends AbstractTests { private static final int ID_MOVIE_FIGHT_CLUB = 550; private static final int ID_TV_WALKING_DEAD = 1402; - public TmdbAccountTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbAuthenticationTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbAuthenticationTest.java index f6e426558..293d383fc 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbAuthenticationTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbAuthenticationTest.java @@ -39,9 +39,6 @@ public class TmdbAuthenticationTest extends AbstractTests { private static TmdbAuthentication instance; - public TmdbAuthenticationTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); @@ -64,7 +61,7 @@ public class TmdbAuthenticationTest extends AbstractTests { /** * Test of getSessionToken method, of class TmdbAuthentication. * - * TODO: Cannot be tested without a HTTP authorisation:
+ * Cannot be tested without a HTTP authorisation:
* http://help.themoviedb.org/kb/api/user-authentication * * @throws com.omertron.themoviedbapi.MovieDbException @@ -98,7 +95,7 @@ public class TmdbAuthenticationTest extends AbstractTests { */ @Test public void testGetSessionTokenLogin() throws MovieDbException { - System.out.println("getSessionTokenLogin"); + LOG.info("getSessionTokenLogin"); TokenAuthorisation token = instance.getAuthorisationToken(); TokenAuthorisation result = instance.getSessionTokenLogin(token, getUsername(), getPassword()); assertNotNull("Null token returned", result); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbCertificationsTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbCertificationsTest.java index 2d5699c96..b94711bfe 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbCertificationsTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbCertificationsTest.java @@ -38,9 +38,6 @@ public class TmdbCertificationsTest extends AbstractTests { private static TmdbCertifications instance; - public TmdbCertificationsTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbChangesTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbChangesTest.java index 9edbfffe4..3aea805f5 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbChangesTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbChangesTest.java @@ -36,9 +36,6 @@ public class TmdbChangesTest extends AbstractTests { private static TmdbChanges instance; - public TmdbChangesTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbCollectionsTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbCollectionsTest.java index 1ed1ef844..f701aee03 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbCollectionsTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbCollectionsTest.java @@ -38,9 +38,6 @@ public class TmdbCollectionsTest extends AbstractTests { private static TmdbCollections instance; private static final int ID_COLLECTION_STAR_WARS = 10; - public TmdbCollectionsTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbCompaniesTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbCompaniesTest.java index 012c37f7f..31aa8c366 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbCompaniesTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbCompaniesTest.java @@ -39,9 +39,6 @@ public class TmdbCompaniesTest extends AbstractTests { private static TmdbCompanies instance; private static final int ID_COMPANY = 2; - public TmdbCompaniesTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbConfigurationTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbConfigurationTest.java index e0c8d733d..0fa1a829a 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbConfigurationTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbConfigurationTest.java @@ -42,9 +42,6 @@ public class TmdbConfigurationTest extends AbstractTests { private static TmdbConfiguration instance; - public TmdbConfigurationTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbCreditsTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbCreditsTest.java index 99b4b97cc..f207a0ba8 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbCreditsTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbCreditsTest.java @@ -35,9 +35,6 @@ public class TmdbCreditsTest extends AbstractTests { private static TmdbCredits instance; - public TmdbCreditsTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbDiscoverTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbDiscoverTest.java index 1242cfb9d..fc8339afd 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbDiscoverTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbDiscoverTest.java @@ -37,9 +37,6 @@ public class TmdbDiscoverTest extends AbstractTests { private static TmdbDiscover instance; - public TmdbDiscoverTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbEpisodesTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbEpisodesTest.java index 927bb33a6..36bfd735a 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbEpisodesTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbEpisodesTest.java @@ -54,9 +54,6 @@ public class TmdbEpisodesTest extends AbstractTests { private static final List TV_IDS = new ArrayList<>(); private static final String TESTING = "Testing: {}"; - public TmdbEpisodesTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbFindTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbFindTest.java index 61be8e096..390d76455 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbFindTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbFindTest.java @@ -44,9 +44,6 @@ public class TmdbFindTest extends AbstractTests { private static final List TV_IDS = new ArrayList<>(); private static final String TESTING = "Testing {}"; - public TmdbFindTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbGenresTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbGenresTest.java index dadfcdc89..63a122b06 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbGenresTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbGenresTest.java @@ -40,9 +40,6 @@ public class TmdbGenresTest extends AbstractTests { private static final String LIST_IS_NULL = "List is null"; private static final int ID_GENRE_ACTION = 28; - public TmdbGenresTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbKeywordsTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbKeywordsTest.java index daaaf70d7..51ed61c28 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbKeywordsTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbKeywordsTest.java @@ -38,9 +38,6 @@ public class TmdbKeywordsTest extends AbstractTests { private static TmdbKeywords tmdb; private static final String ID_KEYWORD = "1721"; - public TmdbKeywordsTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbListsTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbListsTest.java index 20113d952..0c553cb22 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbListsTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbListsTest.java @@ -47,9 +47,6 @@ public class TmdbListsTest extends AbstractTests { @Rule public ExpectedException exception = ExpectedException.none(); - public TmdbListsTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbMoviesTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbMoviesTest.java index 3bdf87338..af3bc6d11 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbMoviesTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbMoviesTest.java @@ -66,9 +66,6 @@ public class TmdbMoviesTest extends AbstractTests { private static final List FILM_IDS = new ArrayList<>(); private static final String WRONG_TITLE = "Wrong title"; - public TmdbMoviesTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbNetworksTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbNetworksTest.java index 07b90445e..f164b056a 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbNetworksTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbNetworksTest.java @@ -38,9 +38,6 @@ public class TmdbNetworksTest extends AbstractTests { private static TmdbNetworks instance; private static final List TEST_IDS = new ArrayList<>(); - public TmdbNetworksTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbPeopleTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbPeopleTest.java index 8db7c88d0..1e6d9c5c9 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbPeopleTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbPeopleTest.java @@ -64,9 +64,6 @@ public class TmdbPeopleTest extends AbstractTests { private static final String INCORRECT_ID = "Incorrect ID"; private static final String ID_CAST_CREW = "ID: {}, # Cast: {}, # Crew: {}"; - public TmdbPeopleTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbReviewsTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbReviewsTest.java index 227c5cad6..886fea2c9 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbReviewsTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbReviewsTest.java @@ -37,9 +37,6 @@ public class TmdbReviewsTest extends AbstractTests { private static TmdbReviews instance; - public TmdbReviewsTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbSearchTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbSearchTest.java index 6fa405638..b998ad54d 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbSearchTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbSearchTest.java @@ -45,9 +45,6 @@ public class TmdbSearchTest extends AbstractTests { private static TmdbSearch instance; - public TmdbSearchTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbSeasonsTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbSeasonsTest.java index 0768244b6..c52b42c9a 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbSeasonsTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbSeasonsTest.java @@ -52,9 +52,6 @@ public class TmdbSeasonsTest extends AbstractTests { private static final List TV_IDS = new ArrayList<>(); private static final String TESTING = "Testing: {}"; - public TmdbSeasonsTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration(); diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbTVTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbTVTest.java index 5ca31779a..d321a1cb5 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbTVTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbTVTest.java @@ -65,9 +65,6 @@ public class TmdbTVTest extends AbstractTests { private static TmdbTV instance; private static final List TV_IDS = new ArrayList<>(); - public TmdbTVTest() { - } - @BeforeClass public static void setUpClass() throws MovieDbException { doConfiguration();