From a60d066993c33f770ac9ddf70dcdaf11df011c89 Mon Sep 17 00:00:00 2001
From: Stuart Boston <Stuart.Boston@Gmail.com>
Date: Sat, 7 Mar 2015 08:06:09 +0000
Subject: [PATCH] fixed tests

---
 src/test/java/com/omertron/themoviedbapi/TestID.java     | 8 ++++++++
 .../omertron/themoviedbapi/methods/TmdbEpisodesTest.java | 9 ++++++++-
 .../omertron/themoviedbapi/methods/TmdbPeopleTest.java   | 4 +++-
 .../omertron/themoviedbapi/methods/TmdbSeasonsTest.java  | 7 ++++++-
 4 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/src/test/java/com/omertron/themoviedbapi/TestID.java b/src/test/java/com/omertron/themoviedbapi/TestID.java
index 9f2c932a1..ea24ec8c6 100644
--- a/src/test/java/com/omertron/themoviedbapi/TestID.java
+++ b/src/test/java/com/omertron/themoviedbapi/TestID.java
@@ -19,6 +19,9 @@
  */
 package com.omertron.themoviedbapi;
 
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+
 public class TestID {
 
     private String name;
@@ -74,4 +77,9 @@ public class TestID {
         this.other = other;
     }
 
+    @Override
+    public String toString() {
+        return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
+    }
+
 }
diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbEpisodesTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbEpisodesTest.java
index c4dcc23c6..356d9f286 100644
--- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbEpisodesTest.java
+++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbEpisodesTest.java
@@ -95,6 +95,7 @@ public class TmdbEpisodesTest extends AbstractTests {
         String[] appendToResponse = null;
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             TVEpisodeInfo result = instance.getEpisodeInfo(test.getTmdb(), seasonNumber, episodeNumber, language, appendToResponse);
             TestSuite.test(result);
         }
@@ -124,6 +125,7 @@ public class TmdbEpisodesTest extends AbstractTests {
         int episodeNumber = 1;
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             MediaState result = instance.getEpisodeAccountState(test.getTmdb(), seasonNumber, episodeNumber, getSessionId());
             assertNotNull("Null result", result);
             assertTrue("Invalid rating", result.getRated() > -2f);
@@ -143,6 +145,7 @@ public class TmdbEpisodesTest extends AbstractTests {
         int episodeNumber = 1;
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             MediaCreditList result = instance.getEpisodeCredits(test.getTmdb(), seasonNumber, episodeNumber);
             assertNotNull(result);
             assertFalse(result.getCast().isEmpty());
@@ -175,6 +178,7 @@ public class TmdbEpisodesTest extends AbstractTests {
         String language = LANGUAGE_DEFAULT;
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             ExternalID result = instance.getEpisodeExternalID(test.getTmdb(), seasonNumber, episodeNumber, language);
             assertEquals("Wrong IMDB ID", test.getImdb(), result.getImdbId());
         }
@@ -193,6 +197,7 @@ public class TmdbEpisodesTest extends AbstractTests {
         int episodeNumber = 1;
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             ArtworkResults results = new ArtworkResults();
             ResultList<Artwork> result = instance.getEpisodeImages(test.getTmdb(), seasonNumber, episodeNumber);
             assertFalse("No artwork", result.isEmpty());
@@ -220,6 +225,7 @@ public class TmdbEpisodesTest extends AbstractTests {
         String guestSessionID = null;
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             int rating = TestSuite.randomRating();
             StatusCode result = instance.postEpisodeRating(test.getTmdb(), seasonNumber, episodeNumber, rating, getSessionId(), guestSessionID);
             assertEquals("failed to post rating", 12, result.getCode());
@@ -240,8 +246,9 @@ public class TmdbEpisodesTest extends AbstractTests {
         String language = LANGUAGE_DEFAULT;
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             ResultList<Video> result = instance.getEpisodeVideos(test.getTmdb(), seasonNumber, episodeNumber, language);
-            TestSuite.test(result);
+            // There are very few episodes that have videos
         }
     }
 
diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbPeopleTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbPeopleTest.java
index 39e2c1141..71d489022 100644
--- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbPeopleTest.java
+++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbPeopleTest.java
@@ -303,7 +303,9 @@ public class TmdbPeopleTest extends AbstractTests {
     public void testGetPersonLatest() throws MovieDbException {
         LOG.info("getPersonLatest");
         Person result = instance.getPersonLatest();
-        TestSuite.test(result);
+        // All we get on the latest person is usually id and name
+        assertTrue("No id", result.getId() > 0);
+        assertTrue("No name", StringUtils.isNotBlank(result.getName()));
     }
 
 }
diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbSeasonsTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbSeasonsTest.java
index 82c3abed8..fff4f89ce 100644
--- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbSeasonsTest.java
+++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbSeasonsTest.java
@@ -92,6 +92,7 @@ public class TmdbSeasonsTest extends AbstractTests {
         String[] appendToResponse = null;
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             TVSeasonInfo result = instance.getSeasonInfo(test.getTmdb(), seasonNumber, language, appendToResponse);
             TestSuite.test(result);
         }
@@ -118,6 +119,7 @@ public class TmdbSeasonsTest extends AbstractTests {
         LOG.info("getSeasonAccountState");
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             MediaState result = instance.getSeasonAccountState(test.getTmdb(), getSessionId());
             assertNotNull("Null result", result);
             assertTrue("Invalid rating", result.getRated() > -2f);
@@ -136,11 +138,11 @@ public class TmdbSeasonsTest extends AbstractTests {
         int seasonNumber = 0;
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             MediaCreditList result = instance.getSeasonCredits(test.getTmdb(), seasonNumber);
             assertNotNull(result);
             TestSuite.test(result.getCast());
             TestSuite.test(result.getCrew());
-            TestSuite.test(result.getGuestStars());
 
             boolean found = false;
             for (MediaCreditCast p : result.getCast()) {
@@ -166,6 +168,7 @@ public class TmdbSeasonsTest extends AbstractTests {
         String language = LANGUAGE_DEFAULT;
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             ExternalID result = instance.getSeasonExternalID(test.getTmdb(), seasonNumber, language);
             assertEquals("Wrong IMDB ID", test.getImdb(), result.getImdbId());
         }
@@ -187,6 +190,7 @@ public class TmdbSeasonsTest extends AbstractTests {
         ArtworkResults results = new ArtworkResults();
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             ResultList<Artwork> result = instance.getSeasonImages(test.getTmdb(), seasonNumber, language, includeImageLanguage);
             TestSuite.test(result);
             for (Artwork artwork : result.getResults()) {
@@ -212,6 +216,7 @@ public class TmdbSeasonsTest extends AbstractTests {
         boolean found = false;
 
         for (TestID test : TV_IDS) {
+            LOG.info("Testing: {}", test);
             ResultList<Video> result = instance.getSeasonVideos(test.getTmdb(), seasonNumber, language);
             found = found || !result.isEmpty();
         }