From 84e08a93e2ef8d31909fab855a1558efc02d53a1 Mon Sep 17 00:00:00 2001 From: Zeeshan Asghar Date: Fri, 4 Mar 2016 13:38:09 +0500 Subject: [PATCH] pmd:ConsecutiveAppendsShouldReuse Consecutive Appends Should Reuse --- .../omertron/themoviedbapi/model/AbstractJsonMapping.java | 4 ++-- .../themoviedbapi/model/config/Configuration.java | 3 +-- .../java/com/omertron/themoviedbapi/tools/ApiUrl.java | 8 +++----- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/omertron/themoviedbapi/model/AbstractJsonMapping.java b/src/main/java/com/omertron/themoviedbapi/model/AbstractJsonMapping.java index e8d1ea1a9..433dc1955 100644 --- a/src/main/java/com/omertron/themoviedbapi/model/AbstractJsonMapping.java +++ b/src/main/java/com/omertron/themoviedbapi/model/AbstractJsonMapping.java @@ -45,8 +45,8 @@ public abstract class AbstractJsonMapping implements Serializable { @JsonAnySetter protected void handleUnknown(String key, Object value) { StringBuilder unknown = new StringBuilder(this.getClass().getSimpleName()); - unknown.append(": Unknown property='").append(key); - unknown.append("' value='").append(value).append("'"); + unknown.append(": Unknown property='").append(key) + .append("' value='").append(value).append("'"); LOG.trace(unknown.toString()); } diff --git a/src/main/java/com/omertron/themoviedbapi/model/config/Configuration.java b/src/main/java/com/omertron/themoviedbapi/model/config/Configuration.java index 49b416d3a..7d7dd3035 100644 --- a/src/main/java/com/omertron/themoviedbapi/model/config/Configuration.java +++ b/src/main/java/com/omertron/themoviedbapi/model/config/Configuration.java @@ -199,8 +199,7 @@ public class Configuration extends AbstractJsonMapping implements Serializable { } StringBuilder sb = new StringBuilder(getBaseUrl()); - sb.append(requiredSize); - sb.append(imagePath); + sb.append(requiredSize).append(imagePath); try { return new URL(sb.toString()); diff --git a/src/main/java/com/omertron/themoviedbapi/tools/ApiUrl.java b/src/main/java/com/omertron/themoviedbapi/tools/ApiUrl.java index 75ef5eb4d..c463bf946 100644 --- a/src/main/java/com/omertron/themoviedbapi/tools/ApiUrl.java +++ b/src/main/java/com/omertron/themoviedbapi/tools/ApiUrl.java @@ -144,11 +144,9 @@ public class ApiUrl { // Append the key information urlString.append(DELIMITER_FIRST) .append(Param.API_KEY.getValue()) - .append(apiKey); - - // Append the search term - urlString.append(DELIMITER_SUBSEQUENT); - urlString.append(Param.QUERY.getValue()); + .append(apiKey) + .append(DELIMITER_SUBSEQUENT)// Append the search term + .append(Param.QUERY.getValue()); String query = (String) params.get(Param.QUERY);